joroKr21 commented on code in PR #11392:
URL: https://github.com/apache/datafusion/pull/11392#discussion_r1672857688
##########
datafusion/expr/src/udaf.rs:
##########
@@ -72,20 +76,19 @@ pub struct AggregateUDF {
impl PartialEq for AggregateUDF {
fn eq(&self, other: &Self) -> bool {
- self.name() == other.name() && self.signature() == other.signature()
+ self.inner.equals(other.inner.as_ref()) ||
other.inner.equals(self.inner.as_ref())
Review Comment:
The issue with `downcast_ref` is that it's one sided. Perhaps we can
document that and then change the implementation of aliased UDFs to be
symmetric. Should it compare the aliases as well? I'm not sure what would be
correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
