joroKr21 commented on code in PR #11392:
URL: https://github.com/apache/datafusion/pull/11392#discussion_r1672449433
##########
datafusion/expr/src/udaf.rs:
##########
@@ -72,20 +76,19 @@ pub struct AggregateUDF {
impl PartialEq for AggregateUDF {
fn eq(&self, other: &Self) -> bool {
- self.name() == other.name() && self.signature() == other.signature()
+ self.inner.equals(other.inner.as_ref()) ||
other.inner.equals(self.inner.as_ref())
Review Comment:
I'm not sure if we want to be so general but the issue with dynamic equality
is that it might not be symmetric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
