coderfender commented on code in PR #3351:
URL: https://github.com/apache/datafusion-comet/pull/3351#discussion_r2750365216
##########
.github/workflows/spark_sql_test.yml:
##########
@@ -156,7 +156,7 @@ jobs:
run: |
cd apache-spark
rm -rf /root/.m2/repository/org/apache/parquet # somehow parquet
cache requires cleanups
- ENABLE_COMET=true ENABLE_COMET_ONHEAP=true ${{
matrix.config.scan-env }} ENABLE_COMET_LOG_FALLBACK_REASONS=${{
github.event.inputs.collect-fallback-logs || 'false' }} \
+ ENABLE_COMET=true ENABLE_COMET_ONHEAP=true ENABLE_COMET_WRITER=true
${{ matrix.config.scan-env }} ENABLE_COMET_LOG_FALLBACK_REASONS=${{
github.event.inputs.collect-fallback-logs || 'false' }} \
Review Comment:
We currently dont have the config available in spark tests through
`ENABLE_COMET_WRITER=true` . Perhaps you meant enabling them in the benchmark
suite TPCH / TPCDS as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
