nuno-faria commented on code in PR #1337:
URL:
https://github.com/apache/datafusion-python/pull/1337#discussion_r2751762164
##########
src/catalog.rs:
##########
@@ -146,16 +143,22 @@ impl PyCatalog {
#[pymethods]
impl PySchema {
#[new]
- fn new(schema_provider: Py<PyAny>) -> Self {
- let schema_provider =
+ pub fn new(
Review Comment:
(just wondering, no change needed) I noticed that some exposed methods have
`pub` while others don't. I guess it doesn't make a difference right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
