jonahgao commented on code in PR #11424: URL: https://github.com/apache/datafusion/pull/11424#discussion_r1675619263
########## datafusion/core/tests/dataframe/mod.rs: ########## @@ -212,7 +212,6 @@ async fn test_count_wildcard_on_aggregate() -> Result<()> { let sql_results = ctx .sql("select count(*) from t1") .await? - .select(vec![col("count(*)")])? Review Comment: There seems to be a reason for doing it; I once wanted to remove it as well 😂. See https://github.com/apache/datafusion/pull/10459#discussion_r1598937560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org