jayzhan211 commented on code in PR #11424:
URL: https://github.com/apache/datafusion/pull/11424#discussion_r1675728286
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -212,7 +212,6 @@ async fn test_count_wildcard_on_aggregate() -> Result<()> {
let sql_results = ctx
.sql("select count(*) from t1")
.await?
- .select(vec![col("count(*)")])?
Review Comment:
Cool, but I still don't get it.
> Perhaps it meant to show how to select the count(*) again -- if so maybe
we could update the tests to do something like this (rather than removing it
entirely):
Why do we need to select count again, if it is just to show select twice is
valid, could we do `count(wildcard())` instead of `count(*)`?
For `count(*)`, it directly goes to PlanBuilder and miss the chance for
ExprPlanner rewrite. IMO we should use `count(wildcard())` instead but consider
`select(vec![col("count(*)")])` invalid 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
