alamb commented on code in PR #11424:
URL: https://github.com/apache/datafusion/pull/11424#discussion_r1675739488
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -212,7 +212,6 @@ async fn test_count_wildcard_on_aggregate() -> Result<()> {
let sql_results = ctx
.sql("select count(*) from t1")
.await?
- .select(vec![col("count(*)")])?
Review Comment:
I think the idea was to show that it is possible to select a column named
`"count(*)"` after computing the actual `count(*)` value in a previous plan.
```text
Projection(expr=[col("count(*)")]
Aggregate(agg=[count(*))
Scan(..)
```
If we can remove the code and the test still passes though clearly something
is not working as intended.
Maybe it should be instead `col("count(*)") + lit(1)` so the expression
doesn't get removed by the optimizer 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
