pepijnve commented on code in PR #20138:
URL: https://github.com/apache/datafusion/pull/20138#discussion_r2762630846
##########
datafusion/physical-expr/src/intervals/cp_solver.rs:
##########
@@ -364,7 +364,7 @@ pub fn propagate_comparison(
match op {
Operator::Eq => {
// TODO: Propagation is not possible until we support interval
sets.
- Ok(None)
+ Ok(Some((left_child.clone(), right_child.clone())))
Review Comment:
Based on @berkaysynnada's answer I see I misinterpreted the contract of
`propagate_comparison`. I had assumed it needed to provide a correct stricter
constraint if it could or `None` if it couldn't. If not restricting the child
constraints is valid, which makes perfect sense, then indeed there's just the
situation where we can know for sure that `(left == right) == true`, i.e. two
equal point intervals, that we should return `None`. In all other cases we can
simply retain the existing constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
