evangelisilva commented on PR #20138: URL: https://github.com/apache/datafusion/pull/20138#issuecomment-3905070967
@berkaysynnada I have updated the PR based on your feedback: * **Fixed Formatting**: Ran `cargo fmt` to ensure everything aligns with the project's style. * **Cleaned Diffs**: Removed redundant diffs and kept the changes focused on the fix. * **Added Edge Case Test**: I’ve added a new test case, [analyze_not_eq_infeasible](cci:1://file:///Users/evangelisilva/Documents/datafusion/datafusion/physical-expr/src/analysis.rs:475:4-506:5), in [analysis.rs](cci:7://file:///Users/evangelisilva/Documents/datafusion/datafusion/physical-expr/src/analysis.rs:0:0-0:0). This test specifically verifies that `NOT (a = 0.0)` for a column `a` already fixed at `0.0` correctly results in an `Infeasible` outcome (0.0 selectivity and `None` intervals). Ready for another look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
