alamb commented on code in PR #20193:
URL: https://github.com/apache/datafusion/pull/20193#discussion_r2775070343
##########
datafusion/physical-expr/src/projection.rs:
##########
@@ -842,7 +901,7 @@ pub fn combine_projections(
pub fn update_expr(
expr: &Arc<dyn PhysicalExpr>,
projected_exprs: &[ProjectionExpr],
- sync_with_child: bool,
+ unproject: bool,
Review Comment:
I found this parameter name to be **super** confusing as there are no
"children" involved. I suspect this is historical and predates the work to push
expressions down
`unproject` as the best I could come up with -- but would love some thoughts
on better names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
