adriangb commented on code in PR #20193: URL: https://github.com/apache/datafusion/pull/20193#discussion_r2783315040
########## datafusion/physical-expr/src/projection.rs: ########## @@ -842,7 +901,7 @@ pub fn combine_projections( pub fn update_expr( Review Comment: I think if we were to do this a first step would be to move the logic from `update_expr` into the functions on `ProjectionExprs` and make `update_expr` call those, maybe adding a note that it's "soft deprecated" and we recommend calling `ProjectionExprs` instead? I think that could fit in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
