alamb commented on code in PR #20193:
URL: https://github.com/apache/datafusion/pull/20193#discussion_r2775185496


##########
datafusion/physical-expr/src/projection.rs:
##########
@@ -842,7 +901,7 @@ pub fn combine_projections(
 pub fn update_expr(

Review Comment:
   I contemplated going even farther and deprecating this function (and routing 
everything through ProjectionExprs) but I think that will result in some non 
trivial API churn and I figured we could always do it later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to