timsaucer commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-python/pull/1372#discussion_r2777690436
##########
dev/release/release-tarball.sh:
##########
@@ -43,6 +43,13 @@ fi
version=$1
rc=$2
+read -r -p "Proceed to release tarball for ${version}-rc${rc}? [y/N]: " answer
+answer=${answer:-no}
+if [ "${answer}" != "y" ]; then
+ echo "Cancelled tarball release!"
+ exit 1
+fi
Review Comment:
Can we move it further down in the script? That way it would get through all
of the steps and ask to confirm just before committing. Also if we do that
maybe change the text to something along the lines of "Generated release
tarball at XXX. Proceed to commit to SVN?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
