milenkovicm commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-python/pull/1372#discussion_r2777754133
##########
dev/release/release-tarball.sh:
##########
@@ -43,6 +43,13 @@ fi
version=$1
rc=$2
+read -r -p "Proceed to release tarball for ${version}-rc${rc}? [y/N]: " answer
+answer=${answer:-no}
+if [ "${answer}" != "y" ]; then
+ echo "Cancelled tarball release!"
+ exit 1
+fi
Review Comment:
It would make sense if the script was creating a tarball and performing some
complex logic. However, it’s simply copying the existing tarball from `dev` to
`release` without any tarball manipulation.
I've pushed this update across all other DataFusion repositories. It would
make sense to me if we keep `tarball-release.sh` the same across projects.
If you’re keen on change I’m happy to adapt but I’m feeling a bit stressed
about testing it after this morning. 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
