Prathamesh9284 commented on code in PR #1376:
URL:
https://github.com/apache/datafusion-python/pull/1376#discussion_r2794934677
##########
python/datafusion/substrait.py:
##########
@@ -137,6 +155,29 @@ def deserialize_bytes(proto_bytes: bytes) -> Plan:
"""
return Plan(substrait_internal.Serde.deserialize_bytes(proto_bytes))
+ @staticmethod
+ def serialize_json(sql: str, ctx: SessionContext, path: str |
pathlib.Path) -> None:
Review Comment:
I was originally trying to keep it consistent with Serde.serialize, which
writes the binary plan to a file. But I’m also fine with just returning a JSON
string from Plan.to_json() and letting users handle writing to a file
themselves. Do you have a preference for which approach fits better with the
project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
