Prathamesh9284 commented on code in PR #1376:
URL:
https://github.com/apache/datafusion-python/pull/1376#discussion_r2794985290
##########
python/datafusion/substrait.py:
##########
@@ -67,6 +67,24 @@ def encode(self) -> bytes:
"""
return self.plan_internal.encode()
+ def to_json(self) -> str:
+ """Serialize the plan to a JSON string.
+
+ Returns a JSON string following the Protobuf JSON Mapping.
Review Comment:
I agree the wording isn’t very clear. I’ll rephrase it to make it clearer
that this just returns the Plan in its standard JSON form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]