Prathamesh9284 commented on code in PR #1376:
URL:
https://github.com/apache/datafusion-python/pull/1376#discussion_r2794966854
##########
python/datafusion/substrait.py:
##########
@@ -137,6 +155,29 @@ def deserialize_bytes(proto_bytes: bytes) -> Plan:
"""
return Plan(substrait_internal.Serde.deserialize_bytes(proto_bytes))
+ @staticmethod
+ def serialize_json(sql: str, ctx: SessionContext, path: str |
pathlib.Path) -> None:
+ """Serialize a SQL query to a JSON-formatted Substrait plan file.
Review Comment:
Yes, in the current implementation it writes a JSON-formatted Substrait plan
to a file. I used “serialize” in the same sense as the existing binary
serialize, but I agree the naming may not be very clear here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
