kosiew commented on PR #20202: URL: https://github.com/apache/datafusion/pull/20202#issuecomment-3896222554
@adriangb > review difficulty grows exponentially with PR size. Please ignore the diff in these 2 files. <img width="1468" height="752" alt="image" src="https://github.com/user-attachments/assets/38b73dbf-b3e1-47fb-9d0e-92db643397d9"; /> They are auto-generated by the protobuf codegen in the datafusion-proto crate by these schema changes: - Added PhysicalCastColumnNode and wired it into PhysicalExprNode (new oneof arm). - Added PhysicalCastOptions, FormatOptions, and DurationFormat, plus new cast_options fields and compatibility fields (safe, format_options) on cast nodes. - Added cast_options to PhysicalCastNode. The changes to review are therefore 700+ lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
