adriangb commented on code in PR #20202:
URL: https://github.com/apache/datafusion/pull/20202#discussion_r2804880951
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -1003,6 +1005,41 @@ message PhysicalTryCastNode {
message PhysicalCastNode {
PhysicalExprNode expr = 1;
datafusion_common.ArrowType arrow_type = 2;
+ PhysicalCastOptions cast_options = 3;
+}
+
+message PhysicalCastColumnNode {
+ PhysicalExprNode expr = 1;
+ datafusion_common.Field input_field = 2;
+ datafusion_common.Field target_field = 3;
+ // DEPRECATED: Use cast_options instead of safe/format_options.
+ // These fields retained for backward compatibility with DataFusion < 52.0
+ // When deserializing, safe and format_options are only used if cast_options
is not set.
+ bool safe = 4;
Review Comment:
I'm confused: if this message is new, why do we need backwards compat fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
