kosiew commented on PR #20202:
URL: https://github.com/apache/datafusion/pull/20202#issuecomment-3877017211
@adriangb
> @kosiew could you help me understand your long term vision here? Are we
going to fold cast_column(...) into cast(...) or something else?
Yes, this is the plan:
// Today
CastExpr::new(expr, DataType::Int64) // Fast path for simple casting
CastColumnExpr::new(expr, input_field, target_field) // Schema-aware
// next phaase (#20163 or #20164)
CastExpr::with_schema_fields(expr, input_field, target_field) // New
builder method
// Internally delegates to CastColumnExpr if struct type
> Also at least the PR description is outdated.....and if it is here IMO is
should be it's own PR, it seems like a valuable but drive by improvement
unrelated to the rest of these changes).
Thanks for spotting this.
I reverted the [drive by
refactor](https://github.com/apache/datafusion/pull/20202/commits/96b461414b4e6a49c1b6317ed136bfe5d5a6238d)
but forgot to update PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
