andygrove commented on code in PR #3506:
URL: https://github.com/apache/datafusion-comet/pull/3506#discussion_r2804869967
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -3745,4 +3744,15 @@ mod tests {
assert_eq!(r#"[null]"#, string_array.value(2));
assert_eq!(r#"[]"#, string_array.value(3));
}
+
+ #[test]
+ fn test_cast_supported_boolean_to_string() {
Review Comment:
Thanks for adding a test @coderfender, but this doesn't actually demonstrate
any Comet bug that the code fix is improving.
The code fix is basically saying that we can support cast from utf8 to
boolean where we couldn't before, so I would expect to see a previously ignored
scala test for this cast being enabled, or a new test added for this cast. Does
that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
