andygrove commented on code in PR #3506:
URL: https://github.com/apache/datafusion-comet/pull/3506#discussion_r2804939943
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -3745,4 +3744,15 @@ mod tests {
assert_eq!(r#"[null]"#, string_array.value(2));
assert_eq!(r#"[]"#, string_array.value(3));
}
+
+ #[test]
+ fn test_cast_supported_boolean_to_string() {
Review Comment:
The modified code does not appear to be used anywhere in Comet? I created
https://github.com/apache/datafusion-comet/pull/3513 to remove it. Let's see if
CI passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
