coderfender commented on code in PR #3506:
URL: https://github.com/apache/datafusion-comet/pull/3506#discussion_r2805034610
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -3745,4 +3744,15 @@ mod tests {
assert_eq!(r#"[null]"#, string_array.value(2));
assert_eq!(r#"[]"#, string_array.value(3));
}
+
+ #[test]
+ fn test_cast_supported_boolean_to_string() {
Review Comment:
Thank you . Per my understanding of the flow, these functions are called
when we cast among complex types. However, the scala side of things gates cast
support between complex types and I thought keeping it consistent is a good
idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
