askalt commented on code in PR #20276:
URL: https://github.com/apache/datafusion/pull/20276#discussion_r2807697512
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -248,16 +248,13 @@ impl JoinLeftData {
}
/// Helps to build [`HashJoinExec`].
+///
+/// Builder can be created from an existing [`HashJoinExec`] using
[`From::from`].
+/// In this case, all its fields are inherited. If a field that affects the
node's
+/// properties is modified, they will be automatically recomputed during the
build.
pub struct HashJoinExecBuilder {
Review Comment:
It seems typicaly `into_*` takes `self`, but here `HashJoinExec` is not
clone (as I see from the comment it is done intentionally) so it is always
never could be consumed. Added `builder` instead:
```diff
+ /// Create a builder based on the existing [`HashJoinExec`].
+ ///
+ /// Returned builder preserves all existing fields. If a field
requiring properties
+ /// recomputation is modified, this will be done automatically during
the node build.
+ ///
+ pub fn builder(&self) -> HashJoinExecBuilder {
+ self.into()
+ }
+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
