askalt commented on code in PR #20276:
URL: https://github.com/apache/datafusion/pull/20276#discussion_r2807696199
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -248,16 +248,13 @@ impl JoinLeftData {
}
/// Helps to build [`HashJoinExec`].
+///
Review Comment:
Added a note:
```diff
+/// # Adding setters
+///
+/// When adding a new setter, it is necessary to ensure that the
`preserve_properties`
+/// flag is set to false if modifying the field requires a recomputation of
the plan's
+/// properties.
+///
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
