alamb commented on code in PR #20276:
URL: https://github.com/apache/datafusion/pull/20276#discussion_r2805931214
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -248,16 +248,13 @@ impl JoinLeftData {
}
/// Helps to build [`HashJoinExec`].
+///
+/// Builder can be created from an existing [`HashJoinExec`] using
[`From::from`].
+/// In this case, all its fields are inherited. If a field that affects the
node's
+/// properties is modified, they will be automatically recomputed during the
build.
pub struct HashJoinExecBuilder {
Review Comment:
A minor API suggestion to make this code more discoverable might be to add
an explicit method to `HashJoinExec` such as `into_builder` (and leave the
From impl as well )
Something like
```rust
let builder = hash_join_exec.into_builder()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
