cj-zhukov commented on code in PR #20474:
URL: https://github.com/apache/datafusion/pull/20474#discussion_r2844850601
##########
.github/workflows/rust.yml:
##########
@@ -742,7 +742,33 @@ jobs:
- name: Run examples docs check script
run: |
bash ci/scripts/check_examples_docs.sh
+
+ # This job ensures that sqllogictest (.slt) files do not leave
+ # DataFusion configuration options enabled (e.g. `set ... = true`)
+ # without resetting them back to their default state.
+ #
+ # It runs ci/scripts/check_slt_configs.sh and fails if any
+ # dangling configuration settings are detected.
+ sqllogictest-config-check:
+ name: check sqllogictest configs are properly reset
+ needs: linux-build-lib
Review Comment:
Good point - this job does not depend on the Rust build or any compiled
artifacts, and it only runs a Bash script. I’ll remove the needs:
`linux-build-lib` dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
