cj-zhukov commented on PR #20474: URL: https://github.com/apache/datafusion/pull/20474#issuecomment-3957162614
> Is there a way to do this check in the SLT runner test code itself? e.g. after it runs an SLT file it checks if the config state is dirty and reports it via a warning in test output? I'm not particularly sure of adding more and more bash scripts like this Thank you - that makes sense. I agree that enforcing this at the SLT runner level would be a cleaner and more robust solution than adding additional Bash-based checks in CI. I initially considered implementing this directly in Rust, but the shell script felt like a simpler and less invasive first step. That said, I understand the concern about accumulating more CI scripting logic, and I agree that handling this inside the SLT runner is architecturally the better approach. We can mark this PR as draft (without closing the root issue). I'm going to work on a follow-up PR that implements the check directly in the SLT runner - e.g., verifying after each SLT file execution that the configuration state matches the default and reporting it in the test output. That should give us a more complete and future-proof solution. Let me know if that sounds like a good direction, and I’ll proceed accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
