cj-zhukov commented on code in PR #20474: URL: https://github.com/apache/datafusion/pull/20474#discussion_r2847364598
########## datafusion/sqllogictest/test_files/information_schema_multiple_catalogs.slt: ########## Review Comment: Thank you for pointing this out. You’re right - this is currently a limitation. The script only checks boolean settings enabled via `= true` and does not detect non-boolean configuration changes. At this stage, I’d prefer to keep the script simple rather than significantly increasing its complexity in Bash. If we decide to expand the scope to cover all `SET datafusion.*` mutations (including non-boolean values), I think it would be better to address that in a follow-up by implementing a more robust solution in Rust (e.g., using `nom`). That would allow us to properly track configuration changes and ensure they are restored in a more reliable way. I'm ready to work on this. Happy to hear your thoughts on whether we should keep this PR focused or broaden its scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
