gabotechs commented on code in PR #19469:
URL: https://github.com/apache/datafusion/pull/19469#discussion_r2845016420
##########
datafusion/common/src/config.rs:
##########
@@ -1386,13 +1388,23 @@ impl ConfigOptions {
}
return Ok(());
}
- return ConfigField::set(self, key, value);
+ return ConfigField::set(self, inner_key, value);
+ }
+
+ if !self.extensions.0.contains_key(prefix)
+ && self
+ .extensions
+ .0
+ .contains_key(DATAFUSION_FFI_CONFIG_NAMESPACE)
+ {
+ inner_key = key;
+ prefix = DATAFUSION_FFI_CONFIG_NAMESPACE;
}
Review Comment:
Makes sense, the edge case I was trying to reach is, in a context without
DataFusion Python, if `SET datafusion_ffi.custom_namespace.foo` could break in
an unexpected way, but I imagine the only thing will happen is that both
`datafusion_ffi.custom_namespace.foo` and
`datafusion_ffi.datafusion_ffi.custom_namespace.foo` will be tried and none
will set anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
