gabotechs commented on code in PR #19469:
URL: https://github.com/apache/datafusion/pull/19469#discussion_r2845038767


##########
datafusion/common/src/config.rs:
##########
@@ -1352,6 +1352,8 @@ impl ConfigField for ConfigOptions {
     }
 }
 
+pub const DATAFUSION_FFI_CONFIG_NAMESPACE: &str = "datafusion_ffi";

Review Comment:
   As this is something public, and therefore, part of the public API, it would 
be nice to add a doc comment explaining what it is and how does it work. 
Probably a comment similar to what you posted in 
https://github.com/apache/datafusion/pull/19469/changes#r2842595482 but 
de-Pythonified would be a great doc comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to