iffyio commented on code in PR #2241:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2241#discussion_r2871987568
##########
src/parser/mod.rs:
##########
@@ -13982,7 +13958,7 @@ impl<'a> Parser<'a> {
closing_paren_token: closing_paren_token.into(),
}
};
- if self.parse_keyword(Keyword::FROM) {
+ if dialect_of!(self is HiveDialect) &&
self.parse_keyword(Keyword::FROM) {
Review Comment:
not sure I follow the intent of the PR, is it rather that hive should
support `supports_from_first_select` (i.e. what's the difference in behavior
from hive vs other dialects)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
