Viicos commented on code in PR #2241:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2241#discussion_r2873732759
##########
src/parser/mod.rs:
##########
@@ -13982,7 +13958,7 @@ impl<'a> Parser<'a> {
closing_paren_token: closing_paren_token.into(),
}
};
- if self.parse_keyword(Keyword::FROM) {
+ if dialect_of!(self is HiveDialect) &&
self.parse_keyword(Keyword::FROM) {
Review Comment:
I gave more context in the issue I created; I'm not knowledgeable enough
about Hive to understand if it should support FROM first selects, and it is
unclear (see also
https://github.com/apache/datafusion-sqlparser-rs/pull/235#issuecomment-1189199817)
why this `FROM` token parsing was introduced here. Maybe the intent was indeed
to support FROM first selects, but I'd rather not break things here so that's
why I only gated this `FROM` parsing for Hive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
