coderfender commented on code in PR #3559:
URL: https://github.com/apache/datafusion-comet/pull/3559#discussion_r2893204215
##########
native/spark-expr/src/conversion_funcs/numeric.rs:
##########
@@ -913,6 +963,56 @@ pub(crate) fn cast_int_to_timestamp(
Ok(Arc::new(builder.finish().with_timezone_opt(target_tz.clone())) as
ArrayRef)
}
+pub(crate) fn cast_decimal_to_timestamp(
+ array_ref: &ArrayRef,
+ target_tz: &Option<Arc<str>>,
+ scale: i8,
+) -> SparkResult<ArrayRef> {
+ let arr = array_ref.as_primitive::<Decimal128Type>();
+ let scale_factor = 10_i128.pow(scale as u32);
+ let mut builder = TimestampMicrosecondBuilder::with_capacity(arr.len());
+
+ for i in 0..arr.len() {
+ if arr.is_null(i) {
+ builder.append_null();
+ } else {
+ let value = arr.value(i);
+ // Note: spark's big decimal
+ let value_256 = i256::from_i128(value);
+ let micros_256 = value_256 * i256::from_i128(MICROS_PER_SECOND as
i128);
+ let ts = micros_256 / i256::from_i128(scale_factor);
+ builder.append_value(ts.as_i128() as i64);
Review Comment:
Not sure if we need that email more check at all in decimal casts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
