andygrove commented on code in PR #3652:
URL: https://github.com/apache/datafusion-comet/pull/3652#discussion_r2908604962
##########
native/core/src/execution/jni_api.rs:
##########
@@ -570,10 +571,29 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_executePlan(
let (tx, rx) = mpsc::channel(2);
let mut stream = stream;
get_runtime().spawn(async move {
- while let Some(batch) = stream.next().await {
- if tx.send(batch).await.is_err() {
- break;
+ let result = std::panic::AssertUnwindSafe(async {
Review Comment:
These changes are for catching panics that happen in tokio threads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
