andygrove commented on code in PR #3652:
URL: https://github.com/apache/datafusion-comet/pull/3652#discussion_r2908606726
##########
native/core/src/errors.rs:
##########
@@ -145,7 +145,10 @@ pub enum CometError {
}
pub fn init() {
- std::panic::set_hook(Box::new(|_panic_info| {
+ std::panic::set_hook(Box::new(|panic_info| {
+ // Log the panic message and location to stderr so it is visible in CI
logs
+ // even if the exception message is lost crossing the FFI boundary
+ eprintln!("Comet native panic: {panic_info}");
Review Comment:
This is the main change for improving reporting of panics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
