cj-zhukov commented on code in PR #20838:
URL: https://github.com/apache/datafusion/pull/20838#discussion_r2916067729
##########
datafusion/sqllogictest/src/engines/datafusion_engine/runner.rs:
##########
@@ -38,29 +39,38 @@ pub struct DataFusion {
relative_path: PathBuf,
pb: ProgressBar,
currently_executing_sql_tracker: CurrentlyExecutingSqlTracker,
+ default_config: HashMap<String, Option<String>>,
}
impl DataFusion {
pub fn new(ctx: SessionContext, relative_path: PathBuf, pb: ProgressBar)
-> Self {
+ let default_config = SessionContext::new()
Review Comment:
Good question. The intention here is to compare the configuration after
running an `SLT` file with the default DataFusion configuration rather than the
initial state of the passed `SessionContext`.
The `ctx` passed to `new()` may already contain modified configuration
values before `SLT` execution begins, so capturing its state would not
necessarily represent the default configuration.
Creating a fresh `SessionContext` ensures we capture the true default
configuration and can detect if an `SLT` test leaves configuration values
modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
