cj-zhukov commented on code in PR #20838:
URL: https://github.com/apache/datafusion/pull/20838#discussion_r2916138699
##########
datafusion/sqllogictest/src/engines/datafusion_engine/runner.rs:
##########
@@ -135,6 +145,34 @@ impl sqllogictest::AsyncDB for DataFusion {
async fn shutdown(&mut self) {}
}
+impl Drop for DataFusion {
+ fn drop(&mut self) {
+ let mut changed = false;
+
+ for e in self.ctx.state().config().options().entries() {
+ if self.default_config.get(&e.key) != Some(&e.value) {
Review Comment:
Good point - using `remove()` allows us to also detect configuration entries
that were present initially but removed during execution.
While it is unlikely that `SLT` tests remove configuration settings, this
change makes the check more complete with minimal additional complexity. I will
update the implementation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
