Jefffrey commented on code in PR #20838:
URL: https://github.com/apache/datafusion/pull/20838#discussion_r2922563638
##########
datafusion/sqllogictest/src/engines/datafusion_engine/runner.rs:
##########
@@ -38,29 +39,38 @@ pub struct DataFusion {
relative_path: PathBuf,
pb: ProgressBar,
currently_executing_sql_tracker: CurrentlyExecutingSqlTracker,
+ default_config: HashMap<String, Option<String>>,
}
impl DataFusion {
pub fn new(ctx: SessionContext, relative_path: PathBuf, pb: ProgressBar)
-> Self {
+ let default_config = SessionContext::new()
Review Comment:
I think we should capture the incoming `ctx` state as the default; the idea
is to see the dangling config changes made in the tests, but as highlighted by
@martin-g we can make some config changes before running the actual SLTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
