coderfender commented on code in PR #2897:
URL: https://github.com/apache/datafusion-comet/pull/2897#discussion_r2964269853
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1266,6 +1266,30 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("cast ArrayType to ArrayType") {
+ val types = Seq(
+ BooleanType,
+ StringType,
+ ByteType,
+ IntegerType,
+ LongType,
+ ShortType,
+ DecimalType(10, 2),
+ DecimalType(38, 18))
+ for (fromType <- types) {
+ for (toType <- types) {
+ if (fromType != toType &&
+ !tags
+ .get(s"cast $fromType to $toType")
+ .exists(s => s.contains("org.scalatest.Ignore")) &&
+ Cast.canCast(fromType, toType) &&
+ CometCast.isSupported(fromType, toType, None, CometEvalMode.LEGACY)
== Compatible()) {
+ castTest(generateArrays(100, fromType), ArrayType(toType))
+ }
+ }
+ }
+ }
+
Review Comment:
I believe we should also test out all null / some null / empty arrays ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
