coderfender commented on PR #2897: URL: https://github.com/apache/datafusion-comet/pull/2897#issuecomment-4102472957
@manuzhang , Thank you the code / feature looks good over all to me. It would be great if we could add some more comprehensive tests both on spark and rust side (including different data types, eval modes , edge cases etc) and benchmarks (can be a follow up PR too). Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
