goldmedal commented on code in PR #11452:
URL: https://github.com/apache/datafusion/pull/11452#discussion_r1682783513
##########
datafusion/functions-array/src/make_array.rs:
##########
@@ -131,6 +138,77 @@ impl ScalarUDFImpl for MakeArray {
}
}
+#[derive(Debug)]
+pub struct MakeArrayStrict {
Review Comment:
I have some concerns for it. If we make `MapFunc` to accept one array, it
would be used like
```
SELECT map([1,2,3,'a','b','c'])
```
After planning, the input array would be `['1','2','3','a','b','c']` because
of the type coercion for array elements. I think the behavior is wrong. If we
change the signature of `MapFunc`, we might need to have another implementation
to solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
