jayzhan211 commented on code in PR #11452:
URL: https://github.com/apache/datafusion/pull/11452#discussion_r1682861404
##########
datafusion/sqllogictest/test_files/map.slt:
##########
@@ -131,17 +131,23 @@ SELECT MAKE_MAP([1,2], ['a', 'b'], [3,4], ['b']);
----
{[1, 2]: [a, b], [3, 4]: [b]}
-query error
+query ?
SELECT MAKE_MAP('POST', 41, 'HEAD', 'ab', 'PATCH', 30);
+----
+{POST: 41, HEAD: ab, PATCH: 30}
Review Comment:
Alright, so the behaviour is actually depend on `array` itself.
I think we can use `make_array` in this case.
But, if we want to introduce nice dataframe API `map(keys: Vec<Expr>,
values: Vec<Expr>)`, I think we still need to pass `Vec<Expr>` instead of the
result of `make_array`. However, we can introduce that in another PR.
current API expects `map(vec![make_array(vec![lit("a"), lit("b")]),
make_array(vec![lit("1"), lit("2")])])`
a slightly better API is `map(vec![lit("a"), lit("b")], vec![lit(1),
lit(2)])`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
