jayzhan211 commented on code in PR #11452:
URL: https://github.com/apache/datafusion/pull/11452#discussion_r1684115054
##########
datafusion/sqllogictest/test_files/map.slt:
##########
@@ -131,17 +131,23 @@ SELECT MAKE_MAP([1,2], ['a', 'b'], [3,4], ['b']);
----
{[1, 2]: [a, b], [3, 4]: [b]}
-query error
+query ?
SELECT MAKE_MAP('POST', 41, 'HEAD', 'ab', 'PATCH', 30);
+----
+{POST: 41, HEAD: ab, PATCH: 30}
Review Comment:
dataframe API is used for building `Expr`.
`map(vec![make_array(vec![lit("a"), lit("b")]), make_array(vec![lit("1"),
lit("2")])])` is actually like `Expr::ScalarFunction(map_udf(), args: ...)`.
The idea is something like
```rust
fn map(keys: Vec<Expr>, values: Vec<Expr>) {
let args: Vec<Expr> = concat (keys, values)
Expr::ScalarFunction(map_udf(), args)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
