asolimando commented on code in PR #21077: URL: https://github.com/apache/datafusion/pull/21077#discussion_r2974092060
########## datafusion/sqllogictest/test_files/parquet_statistics.slt: ########## @@ -59,7 +59,7 @@ query TT EXPLAIN SELECT * FROM test_table WHERE column1 = 1; Review Comment: Thanks for the suggestion! I added tests for additional numeric types (Int8, Int64, Float32) beyond the original Int32/Float64, all producing NDV=Exact(1) as expected. Also added a reversed predicate test (`42 = a` instead of `a = 42`) to confirm operand order doesn't matter. I investigated string (Utf8) and temporal types (Timestamp, Interval) as well: neither collapses to a single-value interval today due to limitations in the constraint propagation solver. I filed separate issues to track those: - #21109 (strings) - #21111 (timestamps/intervals) The test coverage now includes: - Per-type: Int8, Int32, Int64, Float32, Float64 - Predicate shapes: simple equality, OR, AND (multi-column), reversed operands, absent bounds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
