coderfender commented on code in PR #21030: URL: https://github.com/apache/datafusion/pull/21030#discussion_r2984937289
########## datafusion/ffi/src/ffi_option.rs: ########## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! FFI-safe Option and Result types that do not require `IStable` bounds. +//! +//! stabby's `Option<T>` and `Result<T, E>` require `T: IStable` for niche +//! optimization. Many of our FFI structs contain self-referential function +//! pointers and cannot implement `IStable`. These simple `#[repr(C)]` types +//! provide the same FFI-safe semantics without that constraint. + +/// An FFI-safe option type. +#[repr(C, u8)] +#[derive(Debug, Clone)] +pub enum FfiOption<T> { Review Comment: Exactly ! The one place where stabby isnt as good as abi was with the impl of IStable trait. This gave me 2 options (either to implement the trait for arrow types which was laborious and prone to errors and honestly I thought the ROI was not worth it vs implementing a thing wrapper called FFIOption once and use it everywhere else) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
