coderfender commented on code in PR #21030:
URL: https://github.com/apache/datafusion/pull/21030#discussion_r2984941765
##########
datafusion/ffi/src/insert_op.rs:
##########
@@ -15,34 +15,32 @@
// specific language governing permissions and limitations
// under the License.
-use abi_stable::StableAbi;
use datafusion_expr::logical_plan::dml::InsertOp;
/// FFI safe version of [`InsertOp`].
-#[repr(C)]
-#[derive(StableAbi)]
-pub enum FFI_InsertOp {
+#[repr(u8)]
+pub enum FFiInsertOp {
Review Comment:
Sure . My local clippy check failed with naming error. Let me revert to the
original name on main
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -228,30 +229,30 @@ impl From<FFI_Boundedness> for Boundedness {
}
/// FFI safe version of [`EmissionType`].
-#[repr(C)]
-#[derive(Clone, StableAbi)]
-pub enum FFI_EmissionType {
+#[repr(u8)]
+#[derive(Clone)]
+pub enum FfiEmissionType {
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
