cj-zhukov commented on code in PR #20366:
URL: https://github.com/apache/datafusion/pull/20366#discussion_r2988426221
##########
datafusion/functions-aggregate/src/percentile_cont.rs:
##########
@@ -76,9 +76,9 @@ const INTERPOLATION_PRECISION: f64 = 1_000_000.0;
create_func!(PercentileCont, percentile_cont_udaf);
/// Computes the exact percentile continuous of a set of numbers
-pub fn percentile_cont(order_by: Sort, percentile: Expr) -> Expr {
- let expr = order_by.expr.clone();
- let args = vec![expr, percentile];
+pub fn percentile_cont(expr: Expr, percentile: Expr, asc: bool) -> Expr {
Review Comment:
Regarding nulls_first / nulls_last - this came up in an earlier discussion
https://github.com/apache/datafusion/pull/20366#discussion_r2887202644. As
clarified there, these ordered-set aggregate functions currently ignore null
values, so specifying null ordering does not have any effect in practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
