cj-zhukov commented on code in PR #20366:
URL: https://github.com/apache/datafusion/pull/20366#discussion_r2988464689
##########
docs/source/library-user-guide/upgrading/54.0.0.md:
##########
@@ -91,6 +91,95 @@ fn apply_expressions(
Ok(tnr)
}
+### Ordered-set aggregate DataFrame API simplified
+
+The DataFrame APIs for the following ordered-set aggregate functions have
changed:
+
+- `percentile_cont`
+- `approx_percentile_cont`
+- `approx_percentile_cont_with_weight`
+
+Previously, these functions required a `Sort` expression as input.
+They now accept the value expression `expr` directly along with an `asc: bool`
+parameter to specify sort direction.
+
+This change simplifies the API and removes the need to manually construct
+a `Sort` expression.
Review Comment:
My understanding from the original issue was:
- simplify the API by removing the need to construct a `Sort` expression
I agree it's worth confirming that the simplification justifies the API
churn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
