comphead commented on code in PR #11218:
URL: https://github.com/apache/datafusion/pull/11218#discussion_r1683602389
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -180,6 +180,26 @@ async fn merge_join() {
])
.with_memory_limit(1_000)
.with_config(config)
+ .with_scenario(Scenario::AccessLogStreaming)
+ .run()
+ .await
+}
+
+#[tokio::test]
+async fn sort_merge_join_spill() {
Review Comment:
unfortunately exactly this test case we cannot access any spilling metrics,
but there is another test above `sort_merge_join_no_spill` which is exactly the
same but expectedly fails by mem issue and have the spilling disabled
explicitly. This test passes without issues and with spilling enabled so we can
conclude the spilling happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
